Skip to content

fix(@angular/build): Initiate PostCSS only once #27807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

alan-agius4
Copy link
Collaborator

Previously, PostCSS was initialized three times (once for each preprocessor), resulting in plugins being applied multiple times to each instance. This issue occured due to a race condition triggered by multiple esbuild plugins.

Fixes #27804

@alan-agius4 alan-agius4 force-pushed the postcss-single branch 2 times, most recently from 826c273 to 61d9706 Compare June 10, 2024 10:00
@alan-agius4 alan-agius4 changed the title Update(@angular/build): Initiate PostCSS only once fix(@angular/build): Initiate PostCSS only once Jun 10, 2024
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 10, 2024
@alan-agius4 alan-agius4 requested a review from clydin June 10, 2024 10:10
Previously, PostCSS was initialized three times (once for each preprocessor), resulting in plugins being applied multiple times to each instance. This issue occured due to a race condition triggered by multiple esbuild plugins.

Fixes angular#27804
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 10, 2024
@clydin clydin merged commit f102f81 into angular:main Jun 10, 2024
31 checks passed
@clydin
Copy link
Member

clydin commented Jun 10, 2024

The changes were merged into the following branches: main, 18.0.x

@alan-agius4 alan-agius4 deleted the postcss-single branch June 10, 2024 19:29
@alan-agius4 alan-agius4 self-assigned this Jun 12, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

postcss in Angular 18+ version running twice
2 participants